couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: Fauxton: Implement a filter for changes
Date Thu, 08 May 2014 19:47:52 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/227

    Fauxton: Implement a filter for changes

    Implement a filter for changes plus some cleanup afterwards
    
    @garrensmith @deathbearbrown what do you think of my second commit where I try to reuse
the duplicated filter code? Maybe there is a better solution, I added it to the view-constructor-function,
but maybe I should create a special `FauxtionApi.FilterView` or something like this, what
do you think?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb 2158-changes-filter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #227
    
----
commit 384640edb981558be90a7595b5f6b69f5b12b40a
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-08T19:26:36Z

    Fauxton: Implement a filter for changes
    
    Closes COUCHDB-2158

commit 630dbcd6c39c1946cc29c89000feb5402855a799
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-08T19:41:31Z

    Reuse filter code
    
    As code is duplicated, I reuse the code with inheritance on
    the view. The filter then can be overwritten if there
    anything special is needed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message