couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: Fauxton: Configurable escaping of notificati...
Date Sun, 04 May 2014 15:00:35 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/224

    Fauxton: Configurable escaping of notifications

    Sometimes we are passing static html-links to the notification-
    helper. With the new setting `escape: false` the escaping for
    the notifications can be disabled.
    
    The default value is that all values are escaped, as long as
    no value with `false` is passed for the option escape.
    `undefined` and other falsy values will not unescape.
    
    I updated all occurences where we are passing html to the
    notifications, and added a comment, that people are careful, when
    the passed message changes to e.g. a dynamic content generated
    from users.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb fix-notification-escaping

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #224
    
----
commit 65254f610ad4a48b4cc5675c5d40f3d69760945e
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-04T14:28:40Z

    Fauxton: Configurable escaping of notifications
    
    Sometimes we are passing static html-links to the notification-
    helper. With the new setting `escape: false` the escaping for
    the notifications can be disabled.
    
    The default value is that all values are escaped, as long as
    no value with `false` is passed for the option escape.
    `undefined` and other falsy values will not unescape.
    
    I updated all occurences where we are passing html to the
    notifications, and added a comment, that people are careful, when
    the passed message changes to e.g. a dynamic content generated
    from users.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message