couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-2234) Multiple issues with sidebar
Date Sat, 31 May 2014 13:43:02 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014648#comment-14014648
] 

ASF GitHub Bot commented on COUCHDB-2234:
-----------------------------------------

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/241

    Fauxton: fix scrollbar-issue - COUCHDB-2234

    This is a sliceoff from #225 where I try to fix the issue with the scrollbars.
    
    - Try to honor borders in calculating the width
    - Adjust magic numbers to new widths of the left area
    - Refactor the header/api-url section
    - Removing the maximum widths of 1400px and 1500px, which caused
      vertical scrollbars to appear at 1400px (which is on top of the
      page content, some hundred pixels away from the left side on
      large screens) on a system like windows
    
    COUCHDB-2234

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb scrollbars

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #241
    
----
commit 138697316690e3ed22e6f4828b742a2b8f167ed5
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-29T19:08:05Z

    remove whitespace

commit 6099cc02c50f84c5cd051df917feb1c3cc09757c
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-29T19:09:45Z

    remove unused configuration for resizable container

commit be3b7d5ed441a1c8ee47e719cadde24222a62c22
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-05-31T13:14:32Z

    Fauxton: fix scrollbar-issue - COUCHDB-2234
    
    - Try to honor borders in calulating the width
    - Adjust magic numbers to new widths of the left area
    - Refactor the header/api-url section
    - Removing the maximum widths of 1400px and 1500px, which caused
      vertical scrollbars to appear at 1400px (which is on top of the
      page content, some hundred pixels away from the left side on
      large screens) on a system like windows
    
    COUCHDB-2234

----


> Multiple issues with sidebar
> ----------------------------
>
>                 Key: COUCHDB-2234
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2234
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Alexander Shorin
>         Attachments: COUCHDB-2234-chromium.png, COUCHDB-2234-expanded-sidebar.png, COUCHDB-2234-firefox.png,
COUCHDB-2234-small-window.png
>
>
> I'll put all the issues that brought [319c48994|https://github.com/apache/couchdb/commit/319c48994aaff07b3273b489b4b82495c3def7c5]
into single one since if you're going to fix one, you'll eventually have to fix the others.
> 1. z-index issue for firefox: collapse sidebar and scroll down a bit
> 2. For collapsed sidebar version becomes truncated (any browser)
> 2.5 IMHO, but having logo at the bottom is bad idea and it really looks ugly.  (any browser)
> 3. Double horizontal sidebar happened: first for whole page (firefox, chrome), second
one for databases list (firefox, chrome)
> 4. Sidebar menu icons are left aligned while all others are on the center (firefox, chrome)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message