couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-2158) Apply filter with custom params on changes feed page
Date Thu, 29 May 2014 18:47:02 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012696#comment-14012696
] 

ASF GitHub Bot commented on COUCHDB-2158:
-----------------------------------------

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/227#issuecomment-44568816
  
    Here are my problems I had with the RouteObject and testing:
    
    The event delegation and EventBus is coupled to the RouteObject. Instead testing of a
ViewComponent and a View which are talking to each other I have to initialize the RouteObject
(and probably stub away methods), so the Components are not testable as standalone views any
more but are coupled to another dependency, the RouteObject.
    
    Additionally the FauxtonAPI-Eventbus (`triggerRouteEvent `) is not initialized when just
requiring it, there is some magic missing. Therefore I had to stub it away in the tests:
    https://github.com/robertkowalski/couchdb/commit/248a6ec275d832f574c45377083a52ef534171f5#diff-e635c8b6bc197fb062c62a381b2b92e1R26



> Apply filter with custom params on changes feed page
> ----------------------------------------------------
>
>                 Key: COUCHDB-2158
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2158
>             Project: CouchDB
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Alexander Shorin
>            Assignee: Robert Kowalski
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message