couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-2158) Apply filter with custom params on changes feed page
Date Thu, 29 May 2014 14:47:01 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012404#comment-14012404
] 

ASF GitHub Bot commented on COUCHDB-2158:
-----------------------------------------

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/227#issuecomment-44539512
  
    @garrensmith thank you, you spotted a bug regarding the False filtering (documents have
a deleted: true flag if deleted, but not explicit false when not deleted. Additionally the
filter was case sensitive. I addressed these two problems in 23eafa1 and fcc43cc
    
    I also moved the filter to the top (ee8d7fd) and styled it with a red button and a strong
tag instead of the previously used h6 (db013fb)
    
    In case we want to have more explanation for a filter, we can now set a tooltip text.
this is currently not used, as I also fixed the bug in the filtering (719ee7b)
    
    While I was working in the changes-template I changed <%= to <%- where interpolation
was not needed: e75dd26


> Apply filter with custom params on changes feed page
> ----------------------------------------------------
>
>                 Key: COUCHDB-2158
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2158
>             Project: CouchDB
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Alexander Shorin
>            Assignee: Robert Kowalski
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message