couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb pull request: Add Experimental Content-Security-Policy-Sup...
Date Tue, 20 May 2014 17:58:10 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/233#discussion_r12858278
  
    --- Diff: src/couchdb/couch_httpd_misc_handlers.erl ---
    @@ -79,6 +80,15 @@ handle_utils_dir_req(#httpd{method='GET'}=Req, DocumentRoot) ->
     handle_utils_dir_req(Req, _) ->
         send_method_not_allowed(Req, "GET,HEAD").
     
    +maybe_add_csp_headers(Headers, "false") ->
    +    Headers;
    +maybe_add_csp_headers(Headers, "true") ->
    +    DefaultValues = "default-src 'self'; img-src *; font-src *; " ++
    +                    "script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline';",
    +    Value = couch_config:get("csp", "header_value", DefaultValues),
    +    Headers ++ [{"Content-Security-Policy", Value}].
    --- End diff --
    
    @robertkowalski All good points. I have nothing to say and no objections about, +1.  I'll
quote your statements for docs on CSP about IE support when you merge (or you can add these
to docs by your own as part of this PR).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message