Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5B63102C5 for ; Fri, 4 Apr 2014 20:19:05 +0000 (UTC) Received: (qmail 67263 invoked by uid 500); 4 Apr 2014 20:19:04 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 67161 invoked by uid 500); 4 Apr 2014 20:19:03 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 67153 invoked by uid 99); 4 Apr 2014 20:19:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Apr 2014 20:19:02 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [203.216.7.223] (HELO www.atypical.net) (203.216.7.223) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Apr 2014 20:18:56 +0000 Received: from 69-165-165-30.dsl.teksavvy.com ([69.165.165.30] helo=localhost) by www.atypical.net with esmtps (TLS1.0:RSA_ARCFOUR_MD5:128) (Exim 4.80) (envelope-from ) id 1WWAZP-0002X8-EP for dev@couchdb.apache.org; Sat, 05 Apr 2014 05:18:35 +0900 Date: Fri, 4 Apr 2014 16:18:31 -0400 (EDT) From: Joan Touzet To: dev@couchdb.apache.org Message-ID: <6809156.145.1396642708615.JavaMail.Joan@RITA> In-Reply-To: <485EF20C-42F8-4D0F-9861-770C181DD6CE@apache.org> Subject: Re: [DISCUSS] Erlang whitespace standards (was: [POLL]) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org I intentionally defer here to people actually working in each file. There's nothing worse than someone coming in and excreting all over your favourite thing in the name of some arbitrary standard. That said, if our refactors/rewrites lag too much, we may never get around to fixing things, and that'd be disappointing. Would it be fair to put a line in the sand, say, 12 months out, and strongly suggest that all files be reformatted by then? Or we could tie it to a 2.0 release or similar. -Joan ----- Original Message ----- From: "Robert Samuel Newson" To: dev@couchdb.apache.org Sent: Friday, April 4, 2014 10:33:06 AM Subject: Re: [DISCUSS] Erlang whitespace standards (was: [POLL]) I appreciate firming up a consensus on indentation styles but I want to be clearly -1 on a codebase-wide reformatting for the foreseeable future. Beyond the merges, we have active branches for older releases, the more reformatting we do, the harder back- and forward-porting becomes. I like the idea of being more consistent for future work and, where code is particularly crufty, refactoring before making a change. The "worst" formatted code in couchdb is generally the oldest, and much of that needs a refactor/rewrite as we get to it. B.