Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C8B49100EB for ; Wed, 9 Apr 2014 08:06:03 +0000 (UTC) Received: (qmail 61996 invoked by uid 500); 9 Apr 2014 08:06:02 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 61648 invoked by uid 500); 9 Apr 2014 08:06:01 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 61613 invoked by uid 99); 9 Apr 2014 08:05:59 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2014 08:05:59 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 94CA6950821; Wed, 9 Apr 2014 08:05:58 +0000 (UTC) From: garrensmith To: dev@couchdb.apache.org Reply-To: dev@couchdb.apache.org References: In-Reply-To: Subject: [GitHub] couchdb pull request: 2125 sort tasks refactor Content-Type: text/plain Message-Id: <20140409080558.94CA6950821@tyr.zones.apache.org> Date: Wed, 9 Apr 2014 08:05:58 +0000 (UTC) Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/203#issuecomment-39938213 Hey @robertkowalski, I haven't had a chance to test it yet. But I've taken a look at the code and given some feedback. Most of the feedback is just getting it to more of the style of the rest of Fauxton. This is a great job, even more so because we have never actually explained this code to you. You are rocking this. I will try and test this a little later and report back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---