couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: Fauxton: do not slice off the error text fro...
Date Sat, 12 Apr 2014 13:46:04 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/207

    Fauxton: do not slice off the error text from erlang errors

    As the erlang errors contain two linebreaks, and the parsing
    function is using linebreaks to separate the messages, the content
    was sliced off, which looked like there would not be enough space
    for the message. In fact it got lost during the parsing.
    
    This tries to normalize the data before and after the parsing,
    it removes the linebreaks of the erlang errors so it is parsed
    right. As the other spaces are no &nspb;-entities it does not hurt
    that the are removed.
    
    **Before:**
    ![bildschirmfoto 2014-04-12 um 14 58 15](https://cloud.githubusercontent.com/assets/298166/2687282/b3ef82f8-c248-11e3-8a08-92fc11cab7e1.png)
    
    
    **Now**:
    ![bildschirmfoto 2014-04-12 um 15 31 43](https://cloud.githubusercontent.com/assets/298166/2687279/8d7ae662-c248-11e3-92be-26b08fa385dc.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb logs-sliced-off

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #207
    
----
commit 7274188494f6fd343d9a917fa8de642807e9bba4
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-04-12T13:34:10Z

    Fauxton: do not slice off the error text from erlang errors
    
    As the erlang errors contain two linebreaks, and the parsing
    function is using linebreaks to separate the messages, the content
    was sliced off, which looked like there would not be enough space
    for the message. In fact it got lost during the parsing.
    
    This tries to normalize the data before and after the parsing,
    it removes the linebreaks of the erlang errors so it is parsed
    right. As the other spaces are no &nspb;-entities it does not hurt
    that the are removed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message