couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: 2125 sort tasks refactor
Date Tue, 08 Apr 2014 19:48:24 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/203

    2125 sort tasks refactor

    I refactored the Activetasks. 
    
    I was able to delete far more code than adding new code (even with the whitepsace removals
and code formatting) and implementing new stuff that operates on the collection should now
get pretty straightforward. 
    
    I separated the remove whitespace commit and another one, but I can squash / rebase.
    
    Here is what I did:
    - do not use a model as a kind of collection, directly operate on the
      collection which gets filtered for the view
    - remove the view DataSection which acted as layer to fetch collections from
      the model and passed it to a view
    - remove not used html-template
    - format code
    
    This is the base for COUCHDB-2125  but the feature might need some concept and style which
could take some time

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb 2125-sort-tasks-refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #203
    
----
commit 75f9a04e116fcee353e1d81dd61ff69867d868f5
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-04-06T16:17:36Z

    Fauxton: reformat code & remove whitespace

commit 887f004ffbbb1ff04d2e7f686f17b0068228367c
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-04-06T21:15:16Z

    Fauxton: refactor ActiveTasks
    
    - do not use a model as a collection, directly operate on the
      collection which gets filtered for the view
    - remove the view which acted as layer to fetch collections from
      the model and passed it to a view
    - remove not used html-template
    - format code

commit 7090bd51863f9be2bb588a399274a534946dff1a
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-04-06T21:42:04Z

    Fauxton: do not load unnessecary d3 & backbone

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message