couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chewbranca <...@git.apache.org>
Subject [GitHub] couchdb-couch-mrview pull request: 1993 bigcouch couch mrview
Date Tue, 08 Apr 2014 17:41:23 GMT
Github user chewbranca commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/1#discussion_r11401849
  
    --- Diff: src/couch_mrview.erl ---
    @@ -127,6 +127,10 @@ query_view(Db, {Type, View, Ref}, Args, Callback, Acc) ->
         end.
     
     
    +get_info(Db, DDocId) when is_binary(DDocId) ->
    +    DbName = mem3:dbname(Db#db.name),
    +    {ok, DDoc} = ddoc_cache:open(DbName, DDocId),
    --- End diff --
    
    Interesting idea. `couch_index_server:get_index` already does some similar things in https://github.com/apache/couchdb-couch-index/blob/1843-feature-bigcouch/src/couch_index_server.erl#L64-L97
but that does a `fabric:open_doc` for clustered databases, and `couch_db:open_doc` for local
databases, rather than using the `ddoc_cache:open`. So probably the best approach is to update
`couch_index_server:get_index ` to use `ddoc_cache:open` in both of those code paths, although
I would like to get @davisp's feedback on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message