Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
From: deathbearbrown <git@git.apache.org>
To: dev@couchdb.apache.org
Reply-To: dev@couchdb.apache.org
References: <git-pr-180-couchdb@git.apache.org>
In-Reply-To: <git-pr-180-couchdb@git.apache.org>
Subject: [GitHub] couchdb pull request: Improved Query Options
Content-Type: text/plain
Message-Id: <20140315004658.7582C8B8244@tyr.zones.apache.org>
Date: Sat, 15 Mar 2014 00:46:58 +0000 (UTC)

Github user deathbearbrown commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/180#discussion_r10632272
  
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -1090,20 +1117,48 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb, resizeColum
           this.hasReduce = hasReduce;
           this.render();
         },
    +    getKeys: function(val){
    +      var keys = val.value.replace(/\s/g,"");
    +      
    +      var regKeys = keys.match(/(\[.*?\])/g); 
    +      if (regKeys) {
    +        keys = regKeys;
    +      } else {
    +        keys = keys.split(',');
    +      }
    +
    +      keys = _.map(keys, function (key) { return JSON.parse(key); });
    --- End diff --
    
    Just a note on this one, if we aren't supporting older than IE8, we can use JSON.parse()
    
    @kxepal we originally didn't want to because of a concern around browser support. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---