couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: Fauxton: make hidden tabs in _changes visibl...
Date Sat, 29 Mar 2014 15:59:06 GMT
GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/200

    Fauxton: make hidden tabs in _changes visible

    I found some hidden tabs in the `_changes`-screen I am working on, they are positioned
behind the upper header with the breadcrumbs.
    
    I am not sure if we want them, but I made them visible so everybody can have a look.
    
    I find the tabs very useful, but maybe they should be positioned `fixed` so it's always
in the screen and not just on scrolldown.
    
    **Merge with caution**: if it is planned that e.g. `Config` will get a fixed header like
most views, the padding for tabs makes sense. If not and there would be tabs added, the tabs
would have too much space to the top.
    
    - Should we keep the tabs?
    - Will all screens get this fixed header?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb config/hidden-tabs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #200
    
----
commit c4b8b2b1c91d6acf6388bf191ba36ff60da35d9e
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-03-29T15:44:04Z

    Fauxton: make hidden tabs in _changes visible

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message