couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <>
Subject [GitHub] couchdb pull request: Fix missing file in
Date Sat, 15 Mar 2014 15:07:18 GMT
GitHub user robertkowalski opened a pull request:

    Fix missing file in

    In #181 I have missed to add the test-file to ``. This commit adds the missing
    I will never remember that, so I created a precommit-githook for me now:
    A known issue is that you can have the needed change unstaged, but the test will not fail,
but for me it is okay currently.
    files=$(git diff-index --name-status --cached HEAD | grep -v ^D | cut -c3-)
    # initial commit - files is null
    if [ -z "$files" ]
      files=$(git diff --cached --root --name-status | grep -v ^D | cut -c3-)
    if [ -n "$files" ]
      echo "running"
      for f in $files
        # return error if not in
        if [ -z "$(grep ${f:4} src/" ]
        echo ${f:4}
          if [ "${f:4}" != '' ]
            echo "Error: file not added to"
            exit 1
      exit 0
    PTAL @kxepal 

You can merge this pull request into a Git repository by running:

    $ git pull fix-make-am

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
commit 8b69742d04c5e4b58f3c0d1f354666d70d137133
Author: Robert Kowalski <>
Date:   2014-03-15T15:00:22Z

    Fix missing file in


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message