couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From willholley <...@git.apache.org>
Subject [GitHub] couchdb pull request: Cancel event propagation on replication swap...
Date Mon, 03 Mar 2014 08:09:44 GMT
GitHub user willholley opened a pull request:

    https://github.com/apache/couchdb/pull/161

    Cancel event propagation on replication swap.

    Previous implementation called event.preventDefault() but did not stop upwards propagation
- the click event would trigger navigation to the main database panel. jQuery calls event.preventDefault()
and event.stopPropagation() when false is returned from an event handler so just do that here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/willholley/couchdb 2141-databases-swap-on-replication-page-is-broken

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit b22f2a48c48f3cfa9b4c082cfee87b76e8d44c37
Author: Will Holley <willholley@gmail.com>
Date:   2014-02-28T15:07:13Z

    Cancel event propagation on replication swap.
    
    Previous implementation called e.preventDefault() but did not stop upwards
    propagation - the click event would therefore trigger navigation to the main
    database panel. jQuery calls preventDefault and stopPropagation
    when false is returned from an event handler so just do that here.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message