couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chewbranca <>
Subject [GitHub] couchdb-fabric pull request: 1993 bigcouch couch mrview
Date Fri, 28 Mar 2014 20:29:56 GMT
GitHub user chewbranca opened a pull request:

    1993 bigcouch couch mrview


You can merge this pull request into a Git repository by running:

    $ git pull 1993-bigcouch-couch-mrview

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
commit 28528ace698e46996487d174a2017ecf1a4b9082
Author: Russell Branca <>
Date:   2014-03-27T00:11:26Z

    Switch to using couch_mrview data structures and utility functions
    This updates the data structures expected for view callbacks, mainly
    switching total_and_offset to the new meta response, and also slight
    modifications to the expected row format.
    Additionally this removes view logic from fabric that is better
    handled in couch_mrview.

commit efddaf1d14b19187f31a2c5c19a40061b3635e9a
Author: Russell Branca <>
Date:   2014-03-27T00:25:40Z

    Update fabric_rpc to use couch_mrview
    This modifies fabric_rpc to use couch_mrview for map views, reduce
    views, and all docs queries. This removes the majority of view logic
    from within fabric as it's better handled now in couch_mrview, and
    actually provides pretty drastic decrease in logic in these
    The {view,reduce}_cb functions are also updated to use the new line
    format of couch_mrview, switching total_and_offset to meta and
    updating the row callbacks as well.

commit aeac2dfe5014dc9fe1f10300669ea9244cae3a67
Author: Russell Branca <>
Date:   2014-03-27T22:48:16Z

    Call fabric view reduce callback with meta information
    This is a temporary hack to allow passing meta through
    fabric_view_reduce:handle_message. The meta rows were not present on
    reduce functions in the previous views implementation, but they
    provide an excellent place to determine which a view is about to start
    streaming, which is essential for the multi query view implementation.
    The hack is that we don't do the proper row collection worker dance
    like we do in the handle_message callback for #view_row. For now this
    sets a process dict flag to indicate meta has been sent so that we
    only send it once. The proper fix is to send meta through
    fabric_view:maybe_send_row, but that gets ugly in a hurry and can be
    addressed separately.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message