couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (COUCHDB-1993) Make fabric work with the refactored view engine
Date Fri, 28 Mar 2014 18:45:36 GMT


ASF subversion and git services commented on COUCHDB-1993:

Commit aeac2dfe5014dc9fe1f10300669ea9244cae3a67 in couchdb-fabric's branch refs/heads/1993-bigcouch-couch-mrview
from [~chewbranca]
[;h=aeac2df ]

Call fabric view reduce callback with meta information

This is a temporary hack to allow passing meta through
fabric_view_reduce:handle_message. The meta rows were not present on
reduce functions in the previous views implementation, but they
provide an excellent place to determine which a view is about to start
streaming, which is essential for the multi query view implementation.

The hack is that we don't do the proper row collection worker dance
like we do in the handle_message callback for #view_row. For now this
sets a process dict flag to indicate meta has been sent so that we
only send it once. The proper fix is to send meta through
fabric_view:maybe_send_row, but that gets ugly in a hurry and can be
addressed separately.


> Make fabric work with the refactored view engine
> ------------------------------------------------
>                 Key: COUCHDB-1993
>                 URL:
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: BigCouch
>            Reporter: Volker Mische
>            Assignee: Russell Branca

This message was sent by Atlassian JIRA

View raw message