couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From deathbearbrown <>
Subject [GitHub] couchdb pull request: COUCHDB-2215 Update primary nav.
Date Mon, 31 Mar 2014 20:31:26 GMT
Github user deathbearbrown commented on a diff in the pull request:
    --- Diff: src/fauxton/app/addons/fauxton/base.js ---
    @@ -202,21 +202,17 @@ function(app, FauxtonAPI, resizeColumns) {
         afterRender: function(){
           $('#primary-navbar li[data-nav-name="' + app.selectedHeader + '"]').addClass('active');
    -      var menuOpen = true;
           var $selectorList = $('body');
    -      $('.brand').off();
    -      $('.brand').on({
    +      this.$('.burger').off();
    +      this.$('.burger').on({
    --- End diff --
    Can you move the on Click to a backbone view event?
    like this:
    events: {
    "click .brand":"toggleMenu"
    then make toggleMenu part of the view object, instead of inside the afterRender function.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message