couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb pull request: 1870 add language option to mapreduce editor
Date Fri, 21 Mar 2014 09:36:42 GMT
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb/pull/137#issuecomment-38260382
  
    Refactoring the ViewEditor is a great idea, unfortunately @BigBlueHat this PR is not ready
to be merged into master. Two things need to be done to make it usable. I've added the `session.trigger("authenticated");`
so that  we can check the config only once the user has logged in. Could you add that in.
    
    The second fix is when a user creates a new view. If a user creates a view for an existing
design doc, then they cannot choose the language for the new view but must use the language
that the design doc is set as (unless the design doc is empty, then they can choose which
language to write the new view in). If a user selects a new design doc then the language option
should appear and they can then choose what language this design doc is written in.
    
    Once those two are implemented we should be ready to merge this in. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message