couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb pull request: Improved Query Options
Date Mon, 17 Mar 2014 15:06:16 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/180#discussion_r10659855
  
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -1090,20 +1117,48 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb,
resizeColum
           this.hasReduce = hasReduce;
           this.render();
         },
    +    getKeys: function(val){
    +      var keys = val.value.replace(/\s/g,"");
    +      
    +      var regKeys = keys.match(/(\[.*?\])/g); 
    +      if (regKeys) {
    +        keys = regKeys;
    +      } else {
    +        keys = keys.split(',');
    +      }
    +
    +      keys = _.map(keys, function (key) { return JSON.parse(key); });
    --- End diff --
    
    How about to a bit simplify the logic: try `JSON.parse(val.value)` first. If it fails
- wrap it with `[` and `]` and try again? No need to regex, no need to map and make multiple
`JSON.parse` calls.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message