couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <...@git.apache.org>
Subject [GitHub] couchdb pull request: Improved Query Options
Date Mon, 17 Mar 2014 10:24:38 GMT
Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/180#discussion_r10650925
  
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -1090,20 +1117,48 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb,
resizeColum
           this.hasReduce = hasReduce;
           this.render();
         },
    +    getKeys: function(val){
    +      var keys = val.value.replace(/\s/g,"");
    +      
    +      var regKeys = keys.match(/(\[.*?\])/g); 
    +      if (regKeys) {
    +        keys = regKeys;
    +      } else {
    +        keys = keys.split(',');
    +      }
    +
    +      keys = _.map(keys, function (key) { return JSON.parse(key); });
    --- End diff --
    
    See my previous comment to explain why we do all of this. Its because we changing way
the user inputs keys (to make it simpler) to the way Couchdb requires the keys parameter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message