couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garrensmith <>
Subject [GitHub] couchdb pull request: Improved Query Options
Date Mon, 17 Mar 2014 10:22:10 GMT
Github user garrensmith commented on a diff in the pull request:
    --- Diff: src/fauxton/app/addons/documents/views.js ---
    @@ -1090,20 +1117,48 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb,
           this.hasReduce = hasReduce;
    +    getKeys: function(val){
    +      var keys = val.value.replace(/\s/g,"");
    +      var regKeys = keys.match(/(\[.*?\])/g); 
    --- End diff --
    @kxepal this is correct. What we get from the user is a list of keys e.g 1,2,3 or [1,2],[3,4].
We then need to split that string up into individual keys and put it in an array for `keys`
to work. That is what we are doing. The idea around this is so that the user doesn't need
to create an array when adding keys elements. Just a comma separated list.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message