couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb pull request: Fauxton new view creation fix
Date Thu, 13 Mar 2014 15:15:04 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/177#discussion_r10568726
  
    --- Diff: src/fauxton/app/addons/documents/routes.js ---
    @@ -300,6 +292,24 @@ function(app, FauxtonAPI, Documents, Databases) {
           Documents.paginate.reset();
         },
     
    +    createViewDocumentsView: function (designDoc, docParams, urlParams, database, indexedDocs,
designDocs) {
    +       var ddocInfo = {
    +        id: "_design/" + designDocs,
    --- End diff --
    
    I think name isn't good one: at first it raises the thought that this is some kind of
array of design docs, but it seems it's actually `designDocName` which is semi-canonical term
for the right part of `_design/` prefix. Sure no one been confused?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message