couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From deathbearbrown <...@git.apache.org>
Subject [GitHub] couchdb pull request: Some work on Config
Date Thu, 13 Mar 2014 13:50:04 GMT
Github user deathbearbrown commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/174#discussion_r10564483
  
    --- Diff: src/fauxton/app/addons/config/resources.js ---
    @@ -97,22 +98,32 @@ function (app, FauxtonAPI) {
         },
     
         editValue: function (event) {
    -      this.$(".js-show-value").hide();
    -      this.$(".js-edit-value-form").show();
    +      this.$(".js-show-value").addClass("js-hidden");
    +      this.$(".js-edit-value-form").removeClass("js-hidden");
    --- End diff --
    
    The best thing to do is add/remove classes as Robert as done.  
    The fast thing to do is use show/hide. 
    Since we have been sprinting to get these addons done, it's nice to go back and clean
that codesmell up. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message