couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb pull request: Some work on Config
Date Wed, 12 Mar 2014 21:33:03 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/174#discussion_r10542268
  
    --- Diff: src/fauxton/app/addons/config/resources.js ---
    @@ -97,22 +98,32 @@ function (app, FauxtonAPI) {
         },
     
         editValue: function (event) {
    -      this.$(".js-show-value").hide();
    -      this.$(".js-edit-value-form").show();
    +      this.$(".js-show-value").addClass("js-hidden");
    +      this.$(".js-edit-value-form").removeClass("js-hidden");
    --- End diff --
    
    Hm. I wondering if it's possible to redefine `show`/`hide` to let them apply this class
instead of inline style. Just have a bad feeling that there is more than one way to do the
same thing and it's easy to let have both ways in code base. 
    
    But anyway, this doesn't blocks. I'm just curious (:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message