couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertkowalski <...@git.apache.org>
Subject [GitHub] couchdb pull request: Some work on Config
Date Wed, 12 Mar 2014 20:53:33 GMT
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/174#discussion_r10540257
  
    --- Diff: src/fauxton/app/addons/config/resources.js ---
    @@ -97,22 +98,32 @@ function (app, FauxtonAPI) {
         },
     
         editValue: function (event) {
    -      this.$(".js-show-value").hide();
    -      this.$(".js-edit-value-form").show();
    +      this.$(".js-show-value").addClass("js-hidden");
    +      this.$(".js-edit-value-form").removeClass("js-hidden");
    --- End diff --
    
    It's common to separate content from design or markup from inline style.
    .show() and .hide() are using inline styling which is also part of the
    markup in
    https://github.com/apache/couchdb/blob/0af1b0959d13641c1e0d9c7e032098914581735e/src/fauxton/app/addons/config/templates/item.html#L25
    
    You don't want to use JavaScript to style a webpage, that is what CSS is
    made for. There are alot of reasons against inline-styles, e.g.:
    
     - Consistency,
     - Separation of Concerns
    
    But if you are interested, you can google alot more about the topic!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message