couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kxepal <...@git.apache.org>
Subject [GitHub] couchdb pull request: Some work on Config
Date Wed, 12 Mar 2014 15:23:41 GMT
Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/174#discussion_r10522244
  
    --- Diff: src/fauxton/app/addons/config/resources.js ---
    @@ -97,22 +98,32 @@ function (app, FauxtonAPI) {
         },
     
         editValue: function (event) {
    -      this.$(".js-show-value").hide();
    -      this.$(".js-edit-value-form").show();
    +      this.$(".js-show-value").addClass("js-hidden");
    +      this.$(".js-edit-value-form").removeClass("js-hidden");
    --- End diff --
    
    This looks like degradation: while jQuery provides nicer `hide` and `show` methods, they
being replaced by own `addClass` / `removeClass` . Any practical reasons for that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message