couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From KlausTrainer <...@git.apache.org>
Subject [GitHub] couchdb pull request: Remove client-side password crypto from JS t...
Date Wed, 19 Feb 2014 21:44:55 GMT
GitHub user KlausTrainer opened a pull request:

    https://github.com/apache/couchdb/pull/154

    Remove client-side password crypto from JS tests

    This removes client-side password crypto from the JavaScript tests.
    
    In some JavaScript tests, it has been assumed that SHA-1 is used for the
    password hash in user docs.  Those tests should, however, not rely on
    implementation details of the user authentication hash function, as it
    isn't the goal of those tests to check these.  Furthermore, this causes
    problems when a password scheme is changed, or a new one is introduced.
    
    This work clears the way for solving COUCHDB-1780 (upgrade users
    password hash on login).  It will prevent problems with tests that would
    fail because they'd be relying on an old password scheme when a
    mechanism for upgrading user docs to a newer password scheme is
    introduced.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/KlausTrainer/couchdb fix-js-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit f8f0dba91a2f8c4408caedfe43a93982c7ed74d7
Author: Klaus Trainer <klaus_trainer@posteo.de>
Date:   2014-02-19T20:30:53Z

    Remove client-side password crypto from JS tests
    
    This removes client-side password crypto from the JavaScript tests.
    
    In some JavaScript tests, it has been assumed that SHA-1 is used for the
    password hash in user docs.  Those tests should, however, not rely on
    implementation details of the user authentication hash function, as it
    isn't the goal of those tests to check these.  Furthermore, this causes
    problems when a password scheme is changed, or a new one is introduced.
    
    This work clears the way for solving COUCHDB-1780 (upgrade users
    password hash on login).  It will prevent problems with tests that would
    fail because they'd be relying on an old password scheme when a
    mechanism for upgrading user docs to a newer password scheme is
    introduced.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

Mime
View raw message