couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-2086) Modal backdrop broken in Chrome
Date Mon, 24 Feb 2014 20:42:36 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910782#comment-13910782
] 

ASF GitHub Bot commented on COUCHDB-2086:
-----------------------------------------

GitHub user BigBlueHat opened a pull request:

    https://github.com/apache/couchdb/pull/156

    Revert "fix right hand side scrolling over navigation"

    This reverts commit e389a8ba2a79da2669b536ca242b5dfdee4faba3.
    
    This is the commit that broke modals.
    
    Reverting it fixes COUCHDB-2086
    
    Fixing the right hand content overlapping the left
    hand navigation will require a bigger fix...
    
    @deathbearbrown @drsm79 @garrensmith reviews welcome. :smile: 
    This sadly was not it...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BigBlueHat/couchdb 2086-Modal-backdrop-broken-in-Chrome

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit bfd177deed589f7e440ee08840a1164fb74f748c
Author: BigBlueHat <byoung@bigbluehat.com>
Date:   2014-02-24T20:39:26Z

    Revert "fix right hand side scrolling over navigation"
    
    This reverts commit e389a8ba2a79da2669b536ca242b5dfdee4faba3.
    
    This is the commit that broke modals.
    
    Reverting it fixes COUCHDB-2086
    
    Fixing the right hand content overlapping the left
    hand navigation will require a bigger fix...
    This sadly was not it...

----


> Modal backdrop broken in Chrome
> -------------------------------
>
>                 Key: COUCHDB-2086
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2086
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Benjamin Young
>            Assignee: Benjamin Young
>
> I broke this inadvertently when fixing the “one-pane” shifting over the navigation
problem:
> https://github.com/apache/couchdb/commit/e389a8ba2a79da2669b536ca242b5dfdee4faba3
> It’s caused by Webkit’s way of fixed positioned elements changing the stacking context:
> http://updates.html5rocks.com/2012/09/Stacking-Changes-Coming-to-position-fixed-elements
> There’s a few ways to fixe it. Here’s one:
> http://stackoverflow.com/questions/19917026/bootstrap-modal-z-index
> Will be working on this tomorrow (14 hours from now), but reporting it to let everyone
know that it’s a) broken and that b) a patch is forthcoming.
> Sorry for the bug.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message