couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1474) jquery.couch.js: cleanup assignment for user_doc.type
Date Sun, 16 Feb 2014 20:44:19 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902829#comment-13902829
] 

ASF GitHub Bot commented on COUCHDB-1474:
-----------------------------------------

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/151

    remove superfluous 'user_doc.type'

    Fixes COUCHDB-1474

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/couchdb fix/1474

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #151
    
----
commit eb9aba31d02449d4d8a474264207de0e06a8f087
Author: Robert Kowalski <rok@kowalski.gd>
Date:   2014-02-16T20:37:44Z

    remove superfluous 'user_doc.type'
    
    Fixes COUCHDB-1474

----


> jquery.couch.js: cleanup assignment for user_doc.type
> -----------------------------------------------------
>
>                 Key: COUCHDB-1474
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1474
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Futon
>    Affects Versions: 1.2
>         Environment: Debian/testing
>            Reporter: St├ęphane Alnet
>            Priority: Trivial
>
> The source code for jquery.couch.js in 1.2 and git master contains:
>   user_doc.type =  user_doc.type = "user" || [];
> in the signup() method. This code makes little sense; thankfully it is equivalent to
the old prepareUserDoc() code:
>   user_doc.type = "user";
> but the extraneous assignment and test should be removed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message