couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benoit Chesneau <bchesn...@gmail.com>
Subject Re: couch-index commit: updated refs/heads/import to 510599f
Date Wed, 05 Feb 2014 14:56:36 GMT
On Wed, Feb 5, 2014 at 3:33 PM, Paul Davis <paul.joseph.davis@gmail.com>wrote:

> No. Why would it?
>
> It may mean that we'd have to duplicate some similar components in
> couch_mrview but we can always factor out commonalities to a library
> app. Having couch_index try and be everything for indexers was the
> wrong approach. Its easy to need to do things slightly differently
> than couch_index allows which means you can't use any of it. Rather
> than try and shoehorn things into the couch_index shape we should undo
> the split and then review things we could turn into library functions
> in the future.
>
>
mm i see. also agree it would be easier.


 On Wed, Feb 5, 2014 at 8:25 AM, Benoit Chesneau <bchesneau@gmail.com>
> wrote:
> > On Wed, Feb 5, 2014 at 3:21 PM, Paul Davis <paul.joseph.davis@gmail.com
> >wrote:
> >
> >> Its possible but given we've talked about removing the entire app I
> >> don't see much point in putting in that much work on it till we figure
> >> out what's going on there.
> >>
> >
> >
> > mmm does merging mrview and couch_index need to remove all the
> possibility
> > to add a new indexer? Was thinking that we could still keep this
> > possibility which would be nice for the geocouch plugin...
> >
> > - benoit
> >
> >
> >
> >
> >> On Wed, Feb 5, 2014 at 12:10 AM, Benoit Chesneau <bchesneau@gmail.com>
> >> wrote:
> >> > hrm why not making it a behaviour instead?
> >> >
> >> > On Wednesday, February 5, 2014, <davisp@apache.org> wrote:
> >> >
> >> >> Updated Branches:
> >> >>   refs/heads/import aeb7911eb -> 510599f10
> >> >>
> >> >>
> >> >> Remove old notes module
> >> >>
> >> >> This module was never intended to be compiled. Including it just
> >> >> confuses rebar so we'll remove it.
> >> >>
> >> >>
> >> >> Project:
> >> http://git-wip-us.apache.org/repos/asf/couchdb-couch-index/repo
> >> >> Commit:
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/couchdb-couch-index/commit/510599f1
> >> >> Tree:
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/couchdb-couch-index/tree/510599f1
> >> >> Diff:
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/couchdb-couch-index/diff/510599f1
> >> >>
> >> >> Branch: refs/heads/import
> >> >> Commit: 510599f103d74729839d210155852e79d1ec8402
> >> >> Parents: aeb7911
> >> >> Author: Paul J. Davis <paul.joseph.davis@gmail.com <javascript:;>>
> >> >> Authored: Tue Feb 4 17:31:52 2014 -0600
> >> >> Committer: Paul J. Davis <paul.joseph.davis@gmail.com<javascript:;>>
> >> >> Committed: Tue Feb 4 17:31:52 2014 -0600
> >> >>
> >> >>
> ----------------------------------------------------------------------
> >> >>  src/couch_index_api.erl | 54
> >> --------------------------------------------
> >> >>  1 file changed, 54 deletions(-)
> >> >>
> ----------------------------------------------------------------------
> >> >>
> >> >>
> >> >>
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf/couchdb-couch-index/blob/510599f1/src/couch_index_api.erl
> >> >>
> ----------------------------------------------------------------------
> >> >> diff --git a/src/couch_index_api.erl b/src/couch_index_api.erl
> >> >> deleted file mode 100644
> >> >> index 9d3a67c..0000000
> >> >> --- a/src/couch_index_api.erl
> >> >> +++ /dev/null
> >> >> @@ -1,54 +0,0 @@
> >> >> -% Licensed under the Apache License, Version 2.0 (the "License");
> you
> >> may
> >> >> not
> >> >> -% use this file except in compliance with the License. You may
> obtain a
> >> >> copy of
> >> >> -% the License at
> >> >> -%
> >> >> -%   http://www.apache.org/licenses/LICENSE-2.0
> >> >> -%
> >> >> -% Unless required by applicable law or agreed to in writing,
> software
> >> >> -% distributed under the License is distributed on an "AS IS" BASIS,
> >> >> WITHOUT
> >> >> -% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> See
> >> the
> >> >> -% License for the specific language governing permissions and
> >> limitations
> >> >> under
> >> >> -% the License.
> >> >> -
> >> >> --module(couch_index_api).
> >> >> -
> >> >> -get(Field, State) ->
> >> >> -    ok.
> >> >> -
> >> >> -init(Db, Ddoc) ->
> >> >> -    ok.
> >> >> -
> >> >> -open(Db, State) ->
> >> >> -    ok.
> >> >> -
> >> >> -close(State) ->
> >> >> -    ok.
> >> >> -
> >> >> -delete(State) ->
> >> >> -    ok.
> >> >> -
> >> >> -reset(State) ->
> >> >> -    ok.
> >> >> -
> >> >> -
> >> >> -start_update(State, PurgedState, NumChanges) ->
> >> >> -    {ok, State}.
> >> >> -
> >> >> -purge(Db, PurgeSeq, PurgedIdRevs, State) ->
> >> >> -    ok.
> >> >> -
> >> >> -process_doc(Doc, Seq, State) ->
> >> >> -    ok.
> >> >> -
> >> >> -finish_update(State) ->
> >> >> -    {ok, State}.
> >> >> -
> >> >> -commit(State) ->
> >> >> -    ok.
> >> >> -
> >> >> -
> >> >> -compact(Parent, State, Opts) ->
> >> >> -    ok.
> >> >> -
> >> >> -swap_compacted(OldState, NewState) ->
> >> >> -    ok.
> >> >>
> >> >>
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message