couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rnewson <>
Subject [GitHub] couchdb pull request: Upgrade password hashes on authentication
Date Wed, 19 Feb 2014 12:03:03 GMT
Github user rnewson commented on a diff in the pull request:
    --- Diff: src/couchdb/couch_httpd_auth.erl ---
    @@ -68,11 +68,13 @@ default_authentication_handler(Req) ->
                 nil ->
                     throw({unauthorized, <<"Name or password is incorrect.">>});
                 UserProps ->
    -                case authenticate(?l2b(Pass), UserProps) of
    +                Password = ?l2b(Pass),
    +                UserProps2 = maybe_upgrade_password_hash(Password, UserProps),
    +                case authenticate(Password, UserProps2) of
                         true ->
    --- End diff --
    the maybe_upgrade should happen here, in the true clause.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at or file a JIRA ticket with INFRA.

View raw message