couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BigBlueHat <...@git.apache.org>
Subject couchdb pull request: Css loading fix
Date Mon, 03 Feb 2014 16:38:20 GMT
GitHub user BigBlueHat opened a pull request:

    https://github.com/apache/couchdb/pull/143

    Css loading fix

    `Gruntfile.js` was processing the LESS files in according to the order in `settings.json`
but then concatenating the CSS files alphabetically from the filesystem. So LESS/CSS was being
written to compensate for the alphabetical order.
    
    This fixes that.
    
    This fix does, however, come with one caveat. It removes loading `*.css` files from the
assets--meaning one can only use `*.less` files when creating an add-on. However, there are
no known uses of `*.css` files in an add-on, and if there are, they can be renamed to `.less`
and have the exact same result--as LESS files can contain just pure CSS and have the same
output (thankfully!).
    
    @deathbearbrown @garrensmith this one's for you. :smile_cat: 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BigBlueHat/couchdb css-loading-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/143.patch

----
commit 8462b9d3dcbd789d4ca61984584c3d284bee486d
Author: BigBlueHat <byoung@bigbluehat.com>
Date:   2014-01-31T21:59:16Z

    fixed settings.json.dev; added fauxton & cachebuster

commit b8fe3cb10299cbabf4274d6071368734c3880511
Author: BigBlueHat <byoung@bigbluehat.com>
Date:   2014-02-03T16:28:09Z

    fixed .css concat ordering in index.css
    
    This change removes the loading of .css files
    from /addons/**/assets/css/*.css. Putting those
    back is an option, but since unused at present
    I saw it as a separate case for adding back
    if/when desired.

----


Mime
View raw message