Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of gs@redcometlabs.com
 designates 74.125.82.53 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\))
Subject: Re: [REVIEW] refactoring api.js to framework
From: Garren Smith <garren@apache.org>
In-Reply-To: 
 <CAHdjipJCu+DzGSxkS-yL9j9fa=zbi_PTo_3dvZPMVdrz-FejUQ@mail.gmail.com>
Date: Mon, 20 Jan 2014 18:58:58 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <3501D3DE-88C9-472A-B925-EC68E0DF62A1@apache.org>
References: <F7B5D8C3-5FAC-457E-AE1E-58A49064265D@apache.org>
 <CAHdjipKniX9TsNyKnd08ZgHvPpBe7HhbcBR6s+SwaX_=NxZeag@mail.gmail.com>
 <CAHdjipJCu+DzGSxkS-yL9j9fa=zbi_PTo_3dvZPMVdrz-FejUQ@mail.gmail.com>
To: dev@couchdb.apache.org


On 20 Jan 2014, at 6:06 PM, Alexander Shorin <kxepal@gmail.com> wrote:

> On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin <kxepal@gmail.com> =
wrote:
>> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith <garren@apache.org> =
wrote:
>>> See Github link for a nice visual diff =
(https://github.com/apache/couchdb/commits/fauxton-file-reorder)
>>=20
>> This one much better:
>> https://github.com/apache/couchdb/compare/fauxton-file-reorder (;
>>=20
>> May be send github PR to let people leave comments right to the code
>> lines they'd like to discuss?
>=20
> For instance, I couldn't reference router.js line 97 to say: what is =
the "aa"?
>=20
>     setModuleRoutes: function() {
>       _.each(LoadAddons.addons, function(module) {
> +        console.log('aa', module);
>         if (module){
>           module.initialize();
>           // This is pure routes the addon provides
Thats some debugging code that slipped through. Thanks for letting me =
know.
>=20
> --
> ,,,^..^,,,