couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Cottlehuber (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1953) Speed up parsing of multipart/related requests
Date Fri, 24 Jan 2014 13:20:37 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880950#comment-13880950
] 

Dave Cottlehuber commented on COUCHDB-1953:
-------------------------------------------

+1 LGTM, also I see a +1 from BenoƮt in the PR.

I pushed a branch 1953-fix-mime-multipart-parsing to ASF, based on ~ 2 weeks ago so it should
merge clean to both master and 1.6.x if required.

The tests1953.erl should go in, and some doc / release note updates too would be fantastic.

> Speed up parsing of multipart/related requests
> ----------------------------------------------
>
>                 Key: COUCHDB-1953
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1953
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>            Reporter: Nick North
>         Attachments: tests1953.erl
>
>
> Parsing of multipart/related requests searches for the MIME boundary string using the
couch_httpd:find_in_binary/2 function, which can be made more efficient.
> When the boundary string is not found in its entirety in the search data, the function
should then look to see if the data ends with a prefix of the string, but it currently looks
for any prefix of the string almost anywhere in the search data.
> A pull request to fix this will be submitted shortly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message