couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1953) Speed up parsing of multipart/related requests
Date Sat, 25 Jan 2014 01:09:43 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881585#comment-13881585
] 

Paul Joseph Davis commented on COUCHDB-1953:
--------------------------------------------

So when I was debugging the slow replication script in the recent replication thread on user@
I got to a point where I decided to apply this. Ended up with a 20x improvement on the test
which brought that slow replication back in line with the non-HTTP versions.

That motivated me to massage the commit from Nick North so that we have the supplied tests
included and everything. I ended up pushing this work to the branch that Dave created:

https://git-wip-us.apache.org/repos/asf?p=couchdb.git;a=log;h=refs/heads/1953-fix-mime-multipart-parsing

Definitely +1 to get this in. This is a super awesome find by Nick.

> Speed up parsing of multipart/related requests
> ----------------------------------------------
>
>                 Key: COUCHDB-1953
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1953
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>            Reporter: Nick North
>         Attachments: tests1953.erl
>
>
> Parsing of multipart/related requests searches for the MIME boundary string using the
couch_httpd:find_in_binary/2 function, which can be made more efficient.
> When the boundary string is not found in its entirety in the search data, the function
should then look to see if the data ends with a prefix of the string, but it currently looks
for any prefix of the string almost anywhere in the search data.
> A pull request to fix this will be submitted shortly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message