couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Shorin <kxe...@gmail.com>
Subject Re: [REVIEW] refactoring api.js to framework
Date Mon, 20 Jan 2014 16:06:55 GMT
On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin <kxepal@gmail.com> wrote:
> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith <garren@apache.org> wrote:
>> See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder)
>
> This one much better:
> https://github.com/apache/couchdb/compare/fauxton-file-reorder (;
>
> May be send github PR to let people leave comments right to the code
> lines they'd like to discuss?

For instance, I couldn't reference router.js line 97 to say: what is the "aa"?

     setModuleRoutes: function() {
       _.each(LoadAddons.addons, function(module) {
+        console.log('aa', module);
         if (module){
           module.initialize();
           // This is pure routes the addon provides



--
,,,^..^,,,

Mime
View raw message