couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick North <nort...@gmail.com>
Subject Committer questions
Date Sun, 19 Jan 2014 13:57:11 GMT
After reading Andy Wenk's really helpful Committer First
Steps<https://wiki.apache.org/couchdb/Committer_First_Steps>guide, I
feel pretty well informed on submitting code CouchDb code, but I
have just a few questions on commit etiquette (commitiquette?). I'm sure
most of these are very obvious to more experienced users, so please bear
with me while I sort out my initial misconceptions.

First I'm wondering about when it's OK to push work to the Apache
repository. If you put out a non-controversial GitHub pull request, and
there are no negative comments after a reasonable time, is it then fine to
push it and merge to master, or does it need more positive confirmation?
I'm hoping it's OK to go ahead, but don't want to raise the wrath of group
by pushing code that needs more review.

When merging a feature branch to merge to master should you use --no-ff?

Are there times when you shouldn't merge to master? At the moment the 1.6
release is underway, but I assume that pushing to master is still OK, as
there is a separate release branch, so it feels as if it should be fine to
merge code as soon s it's ready. Or is that too optimistic?

Thanks for your help, as always,

Nick

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message