couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garren Smith <gar...@apache.org>
Subject Re: [REVIEW] refactoring api.js to framework
Date Mon, 20 Jan 2014 16:58:58 GMT

On 20 Jan 2014, at 6:06 PM, Alexander Shorin <kxepal@gmail.com> wrote:

> On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin <kxepal@gmail.com> wrote:
>> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith <garren@apache.org> wrote:
>>> See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder)
>> 
>> This one much better:
>> https://github.com/apache/couchdb/compare/fauxton-file-reorder (;
>> 
>> May be send github PR to let people leave comments right to the code
>> lines they'd like to discuss?
> 
> For instance, I couldn't reference router.js line 97 to say: what is the "aa"?
> 
>     setModuleRoutes: function() {
>       _.each(LoadAddons.addons, function(module) {
> +        console.log('aa', module);
>         if (module){
>           module.initialize();
>           // This is pure routes the addon provides
Thats some debugging code that slipped through. Thanks for letting me know.
> 
> --
> ,,,^..^,,,


Mime
View raw message