couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick North (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1953) Speed up parsing of multipart/related requests
Date Wed, 04 Dec 2013 09:16:41 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838757#comment-13838757
] 

Nick North commented on COUCHDB-1953:
-------------------------------------

Oh hold on - I missed a bit of parse_multipart_request. The boundary string actually begins
with "\r\n--" so the worst case attachment is one full of "\r" characters. Such as any Windows
text file...

> Speed up parsing of multipart/related requests
> ----------------------------------------------
>
>                 Key: COUCHDB-1953
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1953
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>            Reporter: Nick North
>
> Parsing of multipart/related requests searches for the MIME boundary string using the
couch_httpd:find_in_binary/2 function, which can be made more efficient.
> When the boundary string is not found in its entirety in the search data, the function
should then look to see if the data ends with a prefix of the string, but it currently looks
for any prefix of the string almost anywhere in the search data.
> A pull request to fix this will be submitted shortly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message