couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Spode Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-668) Futon storage is broken for localhost and other "short" domain names
Date Thu, 12 Dec 2013 14:14:08 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846320#comment-13846320
] 

Andrew Spode Miller commented on COUCHDB-668:
---------------------------------------------

It would be nice to have the cookie domain as an OPTION in local.ini. That way, you can have
a cookie that works across subdomains by using a wildcard. 

In the diff above, looking at the code, simply having:

"; domain=." + location.hostname + "; expires=" + date.toGMTString();

Would allow the cookie across all subdomains. Notice the extra dot after the =. This functionality
should be turned off by default, but could be a setting in local.ini.

> Futon storage is broken for localhost and other "short" domain names
> --------------------------------------------------------------------
>
>                 Key: COUCHDB-668
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-668
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Futon
>    Affects Versions: 0.11
>         Environment: Linux (Ubuntu 9.10), Chromium/Firefox/Opera
>            Reporter: Matt Goodall
>            Assignee: Christopher Lenz
>             Fix For: 0.11
>
>         Attachments: futon-cookie-domain.diff
>
>
> Futon's Storage does not save cookies when accessing a Futon on localhost.
> Storage's cookie handler now includes the domain name in the cookie args. That doesn't
work for localhost, and I can't think of a reason why Futon would ever need to explicitly
set the domain anyway.
> Removing the domain arg from the cookie fixes the problem on all tested browsers. I haven't
been able to test on IE to see if it still works there.
> Patch attached.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message