couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garren Smith <gar...@apache.org>
Subject Re: couchdb pull request: Handle req.status == 201
Date Wed, 27 Nov 2013 10:12:28 GMT
What are we going to do with patches for query.couch? It seems everyone is happy to deprecate
it. We just now need someone who would be willing to maintain it outside of the git repo?

Cheers
Garren


On 27 November 2013 at 11:58:11 AM, timblack1 (git@git.apache.org) wrote:

GitHub user timblack1 opened a pull request: 

https://github.com/apache/couchdb/pull/110 

Handle req.status == 201 

The reason for this fix is that without it, bulkSave() returns the following error on line
1029: 

Uncaught The documents could not be saved: undefined 

However, in fact my documents are being saved, so the error message is not correct. 

But because line 993 above reads: 

options = $.extend({successStatus: 200}, options); 

I wonder if there might be a better way to prevent this error message, either in my client
code or maybe by making successStatus be an array of acceptable values. 

You can merge this pull request into a Git repository by running: 

$ git pull https://github.com/timblack1/couchdb patch-3 

Alternatively you can review and apply these changes as the patch at: 

https://github.com/apache/couchdb/pull/110.patch 

---- 
commit 00fa53cbbe2ae468a4bb005ef5707599a36cdeda 
Author: Tim Black <tim@alwaysreformed.com> 
Date: 2013-11-27T09:57:36Z 

Handle req.status == 201 

The reason for this fix is that without it, bulkSave() returns the following error on line
1029: 

Uncaught The documents could not be saved: undefined 

However, in fact my documents are being saved, so the error message is not correct. 

But because line 993 above reads: 

options = $.extend({successStatus: 200}, options); 

I wonder if there might be a better way to prevent this error message, either in my client
code or maybe by making successStatus be an array of acceptable values. 

---- 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message