Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
From: Jan Lehnardt <jan@apache.org>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_ECE22AA8-2630-4B0B-9D23-0638B28B1984";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Message-Id: <D48F8CF9-721E-4381-B24C-5553EC6EF319@apache.org>
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: [1.5.0] Punted for today :(
Date: Fri, 4 Oct 2013 14:14:53 +0200
References: 
 <CAKmKYaBbnX7q4gREESjH_pb-6zEpWy=etXOis8f36qstHTMC3w@mail.gmail.com>
 <CAPaJBx5xYsq=toP57zD586V-qiA3Dhdrh7hLZczCQYTywgRA0g@mail.gmail.com>
To: dev@couchdb.apache.org
In-Reply-To: 
 <CAPaJBx5xYsq=toP57zD586V-qiA3Dhdrh7hLZczCQYTywgRA0g@mail.gmail.com>

--Apple-Mail=_ECE22AA8-2630-4B0B-9D23-0638B28B1984
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252


On Oct 4, 2013, at 14:01 , Noah Slater <nslater@apache.org> wrote:

> "Our PITA build system doesn't correctly understand how to package =
fauxton"
>=20
> The problem is that new files have been added and Autotools hasn't =
been
> told what to do with them.
>=20
> We should be getting in the habit of checking the CI server Jan set =
up,
> which will flag these errors. This is useful for a devs who are adding =
new
> features and who want to check if the build is broken, and for release
> managers.
>=20
> In fact, for devs, if you're adding new files, or moving files around, =
I
> would recommend a quick "./bootstrap && ./configure --disable-tests && =
make
> distcheck" before you commit. This will flag any problems, or bits =
you've
> forgotten to wire up to the build.

I have an eye on CI that `make distcheck` succeeds and they are all =
green,
e.g. `make distcheck` doesn=92t flag missing files like =
`build_candidate.sh`.

We don=92t yet run `build_candidate.sh` automatically, but I plan to add =
that
ASAP, so we find these packaging issues right away.

Thanks for all the other pointers, I=92ll chug through them on the =
course
of the day.

Also, completely forgot about --disable-tests. So good, thanks! :)

Best
Jan
--=20


>=20
> For the release procedure, we should have a step that reminds the RM =
to
> check the CI server. I thought I had added this already, but a quick =
check
> shows that I haven't. (And in fact, the whole Timetable section is =
dated
> and needs to go.)
>=20
> Only in /tmp/build_candidate.sh.bvE8C6/1.5.x/bin: =
erlang-version.escript
>=20
> This file is is not in the Makefile.am at all, so Autotools will =
completely
> ignore it.
>=20
> The line it needs adding to is:
>=20
>    if WINDOWS
>    bin_SCRIPTS =3D couchdb.bat
>    else
>    bin_SCRIPTS =3D couchdb couch-config
>    endif
>=20
> If this is a *nix thing only, then add it to the last line. If it =
works on
> Windows, add it to both.
>=20
> Only in =
/tmp/build_candidate.sh.bvE8C6/1.5.x/share/doc/src/couchapp/views:
> pagination.rst
>=20
> This needs adding to share/doc/build/Makefile.am. See the html_files =
and
> src_files variables.
>=20
> Only in /tmp/build_candidate.sh.bvE8C6/1.5.x/share/www: plugins.html
>=20
> This needs adding to share/Makefile.am. See the =
nobase_dist_localdata_DATA
> variable.
>=20
> Only in /tmp/build_candidate.sh.bvE8C6/1.5.x/src/couch_plugins: =
README.md
>=20
> These need adding to an EXTRA_DIST, or something similar.
>=20
> Only in /tmp/build_candidate.sh.bvE8C6/1.5.x/src: couchjs-node
>=20
> This one is a little more complex.
>=20
> Edit, src/Makefile.am and add this dir to the SUBDIRS variable.
>=20
> Now take one of the Makefile.am files,
> like src/couch_dbupdates/Makefile.am, and copy it to the couchjs-node =
dir.
> Then modify it to suit the contents of that dir. Shout if you need =
help
> with this.
>=20
> Once you've done that, edit configure.ac, and tell it about the new
> Makefile.am by adding this line:
>=20
> AC_CONFIG_FILES([src/couchjs-node/Makefile])
>=20
> (Make sure to add it in the correct location, and sorted =
alphabetically.)
>=20
> Only in /tmp/build_candidate.sh.bvE8C6/1.5.x/share/www: fauxton
>=20
> This one is surprisingly easy for now, as we're bodging it for the =
time
> being. Just edit share/Makefile.am and add all of the files under the
> fauxton dir to the nobase_dist_localdata_DATA variable.
>=20
> Once all of these things have been done, test with:
>=20
> ./bootstrap && ./configure --disable-tests && make distcheck
>=20
> --=20
> Noah Slater
> https://twitter.com/nslater


--Apple-Mail=_ECE22AA8-2630-4B0B-9D23-0638B28B1984
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJSTrE9AAoJENnuAeR4Uq7kLqoQAI3B1CPgoInENwTxEp/qj9y2
yOHbxgYU/1iJms61iPVNxhHO5HnyExjf76mDBLzwlLj/WPeufcG3iLZ7XwuQH54x
GCNi87H/4UaTw296SqW/ZW14lvT5u+oUzaXv4xzWJh6gfLfA0uVJVS2PyZ8J9DGS
ZqG+SYG+IawX8Jf2PTX6Ed5BXL6fjmTBRc3v73pW8b6kjKa8CJQ7O+ZuNR4C655w
n7Dp4zVV2e40y9A6Kfm7ay9eC2eDV3di1QmP9YhRzF9XV5L3pXgTUrloTUDqfeJ/
cESHFeH+agbX1BGLhwDDgHNalQRFTa28mu0fprimU7D67COKiyugauuHipqJ/DP8
Lsmc6U0+knQbHJYpI9t/NhVKjwCQoU0nc8CpDpmXvImnB9muFYzvRUybeYFw6I3M
H3wql0JTDS5T9wtxfzuURdC+gpLiNbuzQZGYMVygTJNh4Mfjgsh0LmZTfJXTwa2Y
Wt6NvYqJ/MHj1/Nb9YH8NXB+h54pwdgfrlOgonyo0sXkQ0qbrR+T2CQDqyRzaE6/
+R/xRgobuaoVgFX0kRbSquodepW7QOHzkgc2hDoQIILWEyAZ+a0XyeJNgtTvsvsq
jiIBERe0rKbvD59/+ybyJCGrf/OOC9QmOgYEyyfCE3uj0Xf+6pU0V7HohCsLWbX3
in/yHd7UUSkpn5Qj3sTy
=ZPI0
-----END PGP SIGNATURE-----

--Apple-Mail=_ECE22AA8-2630-4B0B-9D23-0638B28B1984--