couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Lehnardt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1875) CoffeeScript CommonJS Functions Don't Work
Date Wed, 21 Aug 2013 06:13:52 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745815#comment-13745815
] 

Jan Lehnardt commented on COUCHDB-1875:
---------------------------------------

https://github.com/apache/couchdb/blob/master/share/server/util.js#L92 could be a hint that
module compilation is done using a from of eval at require()-time and that pure CoffeeScript
there obviously fails.

https://github.com/apache/couchdb/blob/master/share/server/util.js#L67 is how we do on-the-fly
compilation of CS to JS at ddoc eval time.

On a glance, it looks like we can just re-use `evaluate_function_source()` to do the trick.

[~anthony.kaufman]: Do you want to try and come up with a fix? :)
                
> CoffeeScript CommonJS Functions Don't Work
> ------------------------------------------
>
>                 Key: COUCHDB-1875
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1875
>             Project: CouchDB
>          Issue Type: Bug
>          Components: JavaScript View Server
>            Reporter: Anthony Kaufman
>
> Reusable CommonJS functions written in CoffeeScript raise exceptions when referenced
from map functions.
> Consider the following Javascript code:
> {code:javascript}
> {
>   lib: {
>     simple: "exports.callback = function() { return 'Simple' }"
>   },
>   test: {
>     map: "function(doc) { emit(require('views/lib/simple').callback(), doc) }"
>   }
> }
> {code} 
> As expected, "Simple" is emitted for the key of every document.
> Now the equivalent CoffeeScript code:
> {code:javascript}
> {
>   lib: {
>     simple: "exports.callback = () -> 'Simple'"
>   },
>   test: {
>     map: "(doc) -> emit(require('views/lib/simple').callback(), doc)"
>   }
> }
> {code}
> The view returns no results and an error for every document is printed to the log file.
For example:
> [info] [<0.7270.11>] OS Process #Port<0.96999> Log :: function raised exception
(new TypeError("require(\"views/lib/simple\").callback is not a function", "undefined", 3))
with doc._id 8117

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message