couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Lehnardt <...@apache.org>
Subject Re: couchdb pull request: Fix CORS error with attachments
Date Sun, 10 Mar 2013 20:49:32 GMT

On Mar 10, 2013, at 21:37 , Noah Slater <nslater@apache.org> wrote:

> Not sure if this is related, but I suggested we try out Review Board a few
> months ago. I have seen it used on other projects when people just want a
> code review before commit. Would people find that useful?

I post to asf git and github which serves as enough of a review system for my work, but I
wouldn’t be opposed if others wanted it.


> 
> 
> On 10 March 2013 20:22, vmx <git@git.apache.org> wrote:
> 
>> GitHub user vmx opened a pull request:
>> 
>>    https://github.com/apache/couchdb/pull/47
>> 
>>    Fix CORS error with attachments
>> 
>>    When attachments were returned (?attachments=true) while CORS was
>>    enabled and used, an error occured. The reason for this error
>>    were headers that were encoded as binaries instead of lists. String
>>    operations on binaries throw errors.
>> 
>>    This commit fixes COUCHDB-1689.
>> 
>> You can merge this pull request into a Git repository by running:
>> 
>>    $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
>> 
>> Alternatively you can review and apply these changes as the patch at:
>> 
>>    https://github.com/apache/couchdb/pull/47.patch
>> 
>> ----
>> commit b0420f9006915149e81607615720f32f21c76725
>> Author: Volker Mische <volker.mische@gmail.com>
>> Date:   2013-03-10T17:34:59Z
>> 
>>    Fix CORS error with attachments
>> 
>>    When attachments were returned (?attachments=true) while CORS was
>>    enabled and used, an error occured. The reason for this error
>>    were headers that were encoded as binaries instead of lists. String
>>    operations on binaries throw errors.
>> 
>>    This commit fixes COUCHDB-1689.
>> 
>> ----
>> 
>> 
> 
> 
> -- 
> NS


Mime
View raw message