couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Lehnardt <...@apache.org>
Subject Re: git commit: Increase test timeout. Take spinning disks into account.
Date Tue, 26 Mar 2013 17:43:11 GMT

On Mar 26, 2013, at 18:39 , Wendall Cada <wendallc@apache.org> wrote:

> On 03/26/2013 06:45 AM, Jan Lehnardt wrote:
>> I’m not sure why this didn’t go into 1.3.x, but it’s probably my
>> fault, sorry about that.
>> 
>> This should go into 1.3.x and we should recast the 1.3.0 vote as rc.3.
>> 
>> Could we get a consensus from the people where this failed on what the
>> timeout should be? For one person on IRC it was 2000, but we can make
>> this bigger if required. Please send in the minimal value for your system
>> where this doesn’t fail for you.
> I agree with this. I have consistent failures with the javascript cli_runner. I've been
playing around with it to get everything passing. The test failures are all timing based from
what I can tell. The setup/teardown happens too fast between several of the tests and it leaves
a hanging couchdb process. The tests eventually time out and fail. Adding more time is just
masking the problem. I still strongly feel these issues are more closely related to having
couchdb stop/start properly. As a stop gap measure, adding more time to specific tests to
ensure that the tear down of the previous step happens is just fine, but this should get a
proper fix at some point in the near future.

This is unrelated to the JS tests, but test/etap/250-*.t

Cheers
Jan
--


> 
> Wendall
>> 
>> Thanks!
>> 
>> Jan
>> --
>> 
>> On Mar 11, 2013, at 14:38 , jan@apache.org wrote:
>> 
>>> Updated Branches:
>>>  refs/heads/master 33013f0d2 -> e68f83535
>>> 
>>> 
>>> Increase test timeout. Take spinning disks into account.
>>> 
>>> 
>>> Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/e68f8353
>>> Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/e68f8353
>>> Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/e68f8353
>>> 
>>> Branch: refs/heads/master
>>> Commit: e68f835354f90238b4e8d7c49da4b16f061dc764
>>> Parents: 33013f0
>>> Author: Jan Lehnardt <jan@apache.org>
>>> Authored: Mon Mar 11 14:38:14 2013 +0100
>>> Committer: Jan Lehnardt <jan@apache.org>
>>> Committed: Mon Mar 11 14:38:14 2013 +0100
>>> 
>>> ----------------------------------------------------------------------
>>> test/etap/250-upgrade-legacy-view-files.t |    2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>> ----------------------------------------------------------------------
>>> 
>>> 
>>> http://git-wip-us.apache.org/repos/asf/couchdb/blob/e68f8353/test/etap/250-upgrade-legacy-view-files.t
>>> ----------------------------------------------------------------------
>>> diff --git a/test/etap/250-upgrade-legacy-view-files.t b/test/etap/250-upgrade-legacy-view-files.t
>>> index 49a65a5..e720b1c 100644
>>> --- a/test/etap/250-upgrade-legacy-view-files.t
>>> +++ b/test/etap/250-upgrade-legacy-view-files.t
>>> @@ -162,7 +162,7 @@ test_upgrade() ->
>>>     % TBD no idea how to actually test this.
>>> 
>>>     % ensure new header.
>>> -    timer:sleep(1000),
>>> +    timer:sleep(2000),
>>>     ensure_header(NewViewFile, fun(#mrheader{}) -> true; (_) -> false end,
"new"),
>>> 
>>>     ok.
>>> 
> 


Mime
View raw message