Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Date: Wed, 2 Jan 2013 21:14:12 +0000 (UTC)
From: "Christopher Bonhage (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Message-ID: <JIRA.12623640.1355355363075.70920.1357161252789@arcas>
In-Reply-To: <JIRA.12623640.1355355363075@arcas>
References: <JIRA.12623640.1355355363075@arcas>
Subject: [jira] [Commented] (COUCHDB-1628) THANKS generation uses a
 non-portable sed extended regexp flag
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542408#comment-13542408 ] 

Christopher Bonhage commented on COUCHDB-1628:
----------------------------------------------

I'm running Oracle Enterprise Linux Server 5.6:

$ cat /proc/version
Linux version 2.6.18-238.12.1.0.1.el5 (mockbuild@ca-build9.us.oracle.com) (gcc version 4.1.2 20080704 (Red Hat 4.1.2-50)) #1 SMP Tue May 31 14:51:07 EDT 2011

$ sed --version
GNU sed version 4.1.5
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE,
to the extent permitted by law.
                
> THANKS generation uses a non-portable sed extended regexp flag
> --------------------------------------------------------------
>
>                 Key: COUCHDB-1628
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1628
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Build System
>            Reporter: Christopher Bonhage
>            Assignee: Jan Lehnardt
>         Attachments: 0001-Fix-BSD-GNU-sed-extended-regex-flag-inconsistency.patch
>
>
> The bootstrap script currently generates a THANKS file by grepping through the git shortlog and running an extended regular expression command on the resulting stream using sed (line 48):
> git shortlog -se 6c976bd..HEAD \
>         | grep -v @apache.org \
>         | sed -E "s/^[[:blank:]]{5}[[:digit:]]+[[:blank:]]/ * /" >> THANKS
> BSD sed uses the '-E' option to interpret regular expressions as extended (modern) regular expressions rather than basic regular expressions (BRE's). GNU sed uses the '-r' option for this behavior.
> The bootstrap script should be modified to detect the proper flag to use. I am currently using a patch which checks the system's uname to determine the flag.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira