Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B413FD823 for ; Fri, 14 Dec 2012 20:38:03 +0000 (UTC) Received: (qmail 4713 invoked by uid 500); 14 Dec 2012 20:38:03 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 4677 invoked by uid 500); 14 Dec 2012 20:38:03 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 4669 invoked by uid 99); 14 Dec 2012 20:38:03 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2012 20:38:03 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.212.52] (HELO mail-vb0-f52.google.com) (209.85.212.52) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2012 20:37:57 +0000 Received: by mail-vb0-f52.google.com with SMTP id ez10so4553486vbb.11 for ; Fri, 14 Dec 2012 12:37:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:content-type:x-gm-message-state; bh=1Erj2YORyGqsGGYEiL2KEsiPg/0Ny1JRp8seq8dBdp8=; b=hVEVp9T9x3LrPPEomhxb2M7INoEGyWu53EzSGDXSOuyjNi8DIhma8jfQ2ImwB0YnNW cPDUFcnGXHzpLAQY9ynsooPa6dd/GPSrygr6nHFILOcM5UKl3aXQBHenvVLK4MNYqvRz Gd0Ov7ICqucnVF1B2X32JK3RX+ky/fh2pr3J6fdljADf5ix8MEhVEkRVZQSUhojydmdv Y4mOnCnyq4AXG2NL9o661S8u201+XYXHTqaCvM0PEsoHDYZjBdKWRC1r8M5naf7ThV1j xXA9t8rkjQr8U97rZm+yt281iHJdpnoefzr6sfYgAnpin319Z4brslyOtjU+YRgBxPj5 yndg== MIME-Version: 1.0 Received: by 10.220.106.147 with SMTP id x19mr11224188vco.37.1355517456451; Fri, 14 Dec 2012 12:37:36 -0800 (PST) Received: by 10.58.80.40 with HTTP; Fri, 14 Dec 2012 12:37:36 -0800 (PST) X-Originating-IP: [84.112.19.176] In-Reply-To: References: Date: Fri, 14 Dec 2012 21:37:36 +0100 Message-ID: Subject: Re: 1.3.x warning -in couch_mrview_show From: Dave Cottlehuber To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlvDfzP4Aq3c3otVAABa9HK4jBPgENrN2jCd4DBKhvT9IavR4GhAaiZe3okmCDhx/XgS55l X-Virus-Checked: Checked by ClamAV on apache.org sweet, swiping it as we speak. Thanks, I was about to push an _ETag instead. On 14 December 2012 21:04, Benoit Chesneau wrote: > On Fri, Dec 14, 2012 at 9:01 PM, Dave Cottlehuber wrote: > >> hey, >> >> I just noticed this warning: >> >> src/couch_mrview_show.erl:253: Warning: variable 'ETag' is unused >> >> during testing for the release. >> >> >> https://github.com/apache/couchdb/blob/1.3.x/src/couch_mrview/src/couch_mrview_show.erl#L253 >> >> Anybody who feels like a quick challenge is welcomed to jump on in and >> have a look, I'm on IRC atm. >> >> A+ >> Dave >> > yeah forgot to port it... > > https://github.com/refuge/couch_core/commit/ccfd4a3b2f6d9536e5b26a094d5615c403570648