couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Newson <robert.new...@gmail.com>
Subject Re: [3/4] git commit: Allow any 2xx code to indicate success
Date Fri, 09 Nov 2012 17:45:40 GMT
Interop with bigcouch when it sends a 202. I just make it more generic to
head off the inevitable next bug. :)


On 9 November 2012 17:38, Benoit Chesneau <bchesneau@gmail.com> wrote:

> just curious what does it solves?
>
> On Fri, Nov 9, 2012 at 6:12 PM,  <rnewson@apache.org> wrote:
> > Allow any 2xx code to indicate success
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/a124976e
> > Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/a124976e
> > Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/a124976e
> >
> > Branch: refs/heads/1.3.x
> > Commit: a124976efa12b5b060f61f93ad3f58dc1986166d
> > Parents: b9af7ea
> > Author: Robert Newson <rnewson@apache.org>
> > Authored: Thu Nov 8 15:32:14 2012 +0000
> > Committer: Robert Newson <rnewson@apache.org>
> > Committed: Thu Nov 8 15:32:22 2012 +0000
> >
> > ----------------------------------------------------------------------
> >  .../src/couch_replicator_httpc.erl                 |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/couchdb/blob/a124976e/src/couch_replicator/src/couch_replicator_httpc.erl
> > ----------------------------------------------------------------------
> > diff --git a/src/couch_replicator/src/couch_replicator_httpc.erl
> b/src/couch_replicator/src/couch_replicator_httpc.erl
> > index 8773383..9c23595 100644
> > --- a/src/couch_replicator/src/couch_replicator_httpc.erl
> > +++ b/src/couch_replicator/src/couch_replicator_httpc.erl
> > @@ -80,7 +80,7 @@ process_response({ibrowse_req_id, ReqId}, Worker,
> HttpDb, Params, Callback) ->
> >  process_response({ok, Code, Headers, Body}, Worker, HttpDb, Params,
> Callback) ->
> >      release_worker(Worker, HttpDb),
> >      case list_to_integer(Code) of
> > -    Ok when Ok =:= 200 ; Ok =:= 201 ; (Ok >= 400 andalso Ok < 500) ->
> > +    Ok when (Ok >= 200 andalso Ok < 300) ; (Ok >= 400 andalso Ok <
500)
> ->
> >          EJson = case Body of
> >          <<>> ->
> >              null;
> > @@ -102,7 +102,7 @@ process_stream_response(ReqId, Worker, HttpDb,
> Params, Callback) ->
> >      receive
> >      {ibrowse_async_headers, ReqId, Code, Headers} ->
> >          case list_to_integer(Code) of
> > -        Ok when Ok =:= 200 ; Ok =:= 201 ; (Ok >= 400 andalso Ok < 500)
> ->
> > +        Ok when (Ok >= 200 andalso Ok < 300) ; (Ok >= 400 andalso Ok <
> 500) ->
> >              StreamDataFun = fun() ->
> >                  stream_data_self(HttpDb, Params, Worker, ReqId,
> Callback)
> >              end,
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message