Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of paul.joseph.davis@gmail.com
 designates 209.85.212.52 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <587752A4-57BF-4B88-8C99-2469C09A8892@apache.org>
References: <20120617193143.A17BA11F83@tyr.zones.apache.org>
 <587752A4-57BF-4B88-8C99-2469C09A8892@apache.org>
From: Paul Davis <paul.joseph.davis@gmail.com>
Date: Sun, 17 Jun 2012 14:40:23 -0500
Message-ID: 
 <CAJ_m3YCWNH5q--hN-kJTCAn7meZK9KhVjy86gwOr-s8TQ5ZcRA@mail.gmail.com>
Subject: Re: [1/2] git commit: fix make distcheck
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Rather than the fancy footwork you could just store the tmp output in
the final file.

On Sun, Jun 17, 2012 at 2:37 PM, Jan Lehnardt <jan@apache.org> wrote:
> Noah, is the use of mktemp okay with regards to the rules for building fr=
om source?
>
> Dave, is mktemp portable in our Windows build system?
>
> Cheers
> Jan
> --
>
> On Jun 17, 2012, at 21:31 , jan@apache.org wrote:
>
>> Updated Branches:
>> =A0refs/heads/master 7646794ea -> d93929fdc
>>
>>
>> fix make distcheck
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/d93929fd
>> Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/d93929fd
>> Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/d93929fd
>>
>> Branch: refs/heads/master
>> Commit: d93929fdccb6f0fe7b205a021558c219c7fbc146
>> Parents: 7f93d33
>> Author: Jan Lehnardt <jan@apache.org>
>> Authored: Sun Jun 17 21:08:35 2012 +0200
>> Committer: Jan Lehnardt <jan@apache.org>
>> Committed: Sun Jun 17 21:08:35 2012 +0200
>>
>> ----------------------------------------------------------------------
>> Makefile.am | =A0 14 ++++++++------
>> 1 files changed, 8 insertions(+), 6 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/couchdb/blob/d93929fd/Makefile.am
>> ----------------------------------------------------------------------
>> diff --git a/Makefile.am b/Makefile.am
>> index 1cbd865..3ffc3df 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -79,15 +79,17 @@ README.gz: $(top_srcdir)/README
>> =A0 =A0 =A0 -gzip -9 < $< > $@
>>
>> THANKS.gz: $(top_srcdir)/THANKS
>> - =A0 =A0 sed -e 's/^#.*//' $< > $<.tmp # strip comments
>> - =A0 =A0 sed -e '/^$$/d' $<.tmp > $<.tmp2 =A0# strip empty lines
>> + =A0 =A0 TMP1=3D`mktemp -t THANKS`
>> + =A0 =A0 TMP2=3D`mktemp -t THANKS`
>> + =A0 =A0 sed -e 's/^#.*//' $< > $TMP1 # strip comments
>> + =A0 =A0 sed -e '/^$$/d' $TMP1 > $TMP2 =A0# strip empty lines
>> =A0 =A0 =A0 git shortlog -se 6c976bd..HEAD \
>> =A0 =A0 =A0 =A0| grep -v @apache.org \
>> =A0 =A0 =A0 =A0| sed -E 's/^[[:blank:]]{5}[[:digit:]]+[[:blank:]]/ * /' =
\
>> - =A0 =A0 =A0>> $<.tmp2 # inject git authors
>> - =A0 =A0 echo '\nFor a list of authors see the `AUTHORS` file.\n' >> $<=
.tmp2
>> - =A0 =A0 -gzip -9 < $<.tmp2 > $@ # zip
>> - =A0 =A0 rm $<.tmp $<.tmp2 # cleanup
>> + =A0 =A0 =A0>> $TMP2 # inject git authors
>> + =A0 =A0 echo '\nFor a list of authors see the `AUTHORS` file.\n' >> $T=
MP2
>> + =A0 =A0 -gzip -9 < $TMP2 > $@ # zip
>> + =A0 =A0 rm $TMP1 $TMP2 # cleanup
>>
>> check: dev check-js
>> =A0 =A0 =A0 $(top_builddir)/test/etap/run $(top_srcdir)/test/etap
>>
>